Feature Request Type

• Core functionality
• Alteration (enhancement/optimization) of existing feature(s)
• New behavior

Description

In the BaseGraphQLTestClient (/test/client.py), there is an option asserts_errors which is by default True, and asserts that response.errors is None.

I'm finding this to be counterintuitive for two reasons:

1. It's not the job of a query client to decide what should be in the response (especially by default), this is the job of my test code ("separation of concerns").
2. It's named incorrectly. "Asserts Errors" implies it asserts that there ARE errors, not that there AREN'T.

I think this check should be removed. If it is kept, the name should be made explicit (assert_no_errors) and ideally made opt-in rather than opt-out.

Special concern

Is it typical for cases to arise in which errors would be returned alongside an otherwise valid response? Because if that's the case then I kind of understand why it's opt-out by default. Otherwise, testing for valid data response should be sufficient, AFAICT?

Contributing

Probably much quicker for a regular maintainer but I'm happy to make a PR for this if accepted!