In the BaseGraphQLTestClient
(/test/client.py
), there is an option asserts_errors
which is by default True
, and asserts that response.errors is None
.
I'm finding this to be counterintuitive for two reasons:
I think this check should be removed. If it is kept, the name should be made explicit (assert_no_errors
) and ideally made opt-in rather than opt-out.
Is it typical for cases to arise in which errors would be returned alongside an otherwise valid response? Because if that's the case then I kind of understand why it's opt-out by default. Otherwise, testing for valid data response should be sufficient, AFAICT?
Probably much quicker for a regular maintainer but I'm happy to make a PR for this if accepted!
Pay now to fund the work behind this issue.
Get updates on progress being made.
Maintainer is rewarded once the issue is completed.
You're funding impactful open source efforts
You want to contribute to this effort
You want to get funding like this too