Git-ignore rules inside a project should not match parts of the absolute path outside the project
- Knip: 5.19.0
- Discord discussion reference (please don't be confused about the symptoms. In the end the problem was found.)
Knip (5.19.0) may behave differently on different environments, depending on
- gitignore rules
- the absolute path, where the project is checked out
During the block
knip/packages/knip/src/util/globby.ts
Line 136 in 7c9b645
** which leads to the problem, that git ignore rules now may match outside the project.
Example:
# .gitignore
# ignore all files in builds folders in the project
builds/// bug in knip
// doesn't match any file, because absolute path matches a gitignore rule
fastGlob(['src/index.ts'], {
cwd: '/Users/xxx/builds/project',
ignore: ['**/builds/**', '**/builds'] // generated from git-ignore
})// maybe-fix in knip
fastGlob(['src/index.ts'], {
cwd: '/Users/xxx/builds/project',
ignore: ['/Users/xxx/builds/project/**/builds/**', '/Users/xxx/builds/project/**/builds'] // fix
})
webpro-nl / knip
✂️ Find unused files, dependencies and exports in your JavaScript and TypeScript projects. Knip it before you ship it!
6.8k
How does funding with Polar work?
1
Pay now to fund the work behind this issue.
2
Get updates on progress being made.
3
Maintainer is rewarded once the issue is completed.
FAQ
Backer
You're funding impactful open source efforts
Contributor
You want to contribute to this effort
Maintainer
You want to get funding like this too