Generics should ignore TypeVars on non-field/argument types
The following code:
import strawberry
from typing import Generic, TypeVar
T = TypeVar("T")
@strawberry.type
class User(Generic[T]):
name: str
age: int
def something(self) -> T:
return 1
@strawberry.type
class Query:
@strawberry.field
def user(self) -> User[int]:
return User(name="Patrick", age=100)
schema = strawberry.Schema(query=Query)generates the following schema:
type IntUser {
name: String!
age: Int!
}
type Query {
user: IntUser!
}I think we could add some more logic to when checking if a type is generic to prevent having generic types when the type vars are not used for field types or for argument types :)
strawberry-graphql / strawberry
A GraphQL library for Python that leverages type annotations 🍓
4.0k
How does funding with Polar work?
1
Pay now to fund the work behind this issue.
2
Get updates on progress being made.
3
Maintainer is rewarded once the issue is completed.
FAQ
Backer
You're funding impactful open source efforts
Contributor
You want to contribute to this effort
Maintainer
You want to get funding like this too