SomeType.from_pydantic(...) does not call resolvers of underlying types
SomeType.from_pydantic(...) does not call resolvers of underlying types.
Or probably I'm doing something wrong. 😄
Describe the Bug
It's better explained as a test:
def test_from_pydantic_calls_underlying_resolvers():
class UserName(BaseModel):
first_name: str
last_name: str
@strawberry.experimental.pydantic.type(UserName)
class UserNameType:
last_name: strawberry.auto
@strawberry.field
def first_name(
self,
root: UserName,
) -> str:
return f"updated {root.first_name}"
class User(BaseModel):
age: int
name: str
@strawberry.experimental.pydantic.type(User)
class UserType:
age: strawberry.auto
@strawberry.field
def name(
self,
root: User,
) -> UserNameType:
first_name, last_name = root.name.split(" ")
return UserNameType.from_pydantic( # <- here's the thing
UserName(first_name=first_name, last_name=last_name)
)
origin_user = User(age=1, name="John Doe")
user = UserType.from_pydantic(origin_user)
assert user.age == 1
assert user.name(origin_user).first_name == "John"Yells:
E AssertionError: assert <bound method test_something.<locals>.UserNameType.first_name of UserNameType(last_name='Doe')> == 'John'
E + where <bound method test_something.<locals>.UserNameType.first_name of UserNameType(last_name='Doe')> = UserNameType(last_name='Doe').first_name
E + where UserNameType(last_name='Doe') = <bound method test_something.<locals>.UserType.name of UserType(age=1)>(User(age=1, name='John Doe'))
E + where <bound method test_something.<locals>.UserType.name of UserType(age=1)> = UserType(age=1).name
However this piece of code works as expected:
@strawberry.experimental.pydantic.type(User)
class UserType:
age: strawberry.auto
@strawberry.field
def name(
self,
root: User,
) -> UserNameType:
first_name, last_name = root.name.split(" ")
# <- note pydantic type is returned instead of `UserType.from_pydantic`
return UserName(first_name=first_name, last_name=last_name)System Information
- Operating system: mac os
- Strawberry version (if applicable): 0.124.0
strawberry-graphql / strawberry
A GraphQL library for Python that leverages type annotations 🍓
4.0k
How does funding with Polar work?
1
Pay now to fund the work behind this issue.
2
Get updates on progress being made.
3
Maintainer is rewarded once the issue is completed.
FAQ
Backer
You're funding impactful open source efforts
Contributor
You want to contribute to this effort
Maintainer
You want to get funding like this too