Fund: Parsing errors are not handled gracefully when `ParserCache` is used

There is this block of code:

Lines 138 to 158 in 24c0f28

    
           with extensions_runner.parsing(): 
        
               try: 
        
                   if not execution_context.graphql_document: 
        
                       execution_context.graphql_document = parse_document(query) 
        
               except GraphQLError as error: 
        
                   execution_context.errors = [error] 
        
                   return ExecutionResult( 
        
                       data=None, 
        
                       errors=[error], 
        
                       extensions=extensions_runner.get_extensions_results_sync(), 
        
                   ) 
        
               except Exception as error:  # pragma: no cover 
        
                   error = GraphQLError(str(error), original_error=error) 
        
                   execution_context.errors = [error] 
        
                   return ExecutionResult( 
        
                       data=None, 
        
                       errors=[error], 
        
                       extensions=extensions_runner.get_extensions_results_sync(), 
        
                   )

If parse_document(query) fails on line 141, the error is handled gracefully.

But if the ParserCache extension is used, a parsing error leads to the 500 error, because parse_document(query) runs as a part of extensions_runner.parsing() that outside the try/except block.

Strawberry GraphQL/strawberry

Parsing errors are not handled gracefully when ParserCache is used

How does funding with Polar work?

Backer

Contributor

Maintainer

	with extensions_runner.parsing():
	try:
	if not execution_context.graphql_document:
	execution_context.graphql_document = parse_document(query)
	except GraphQLError as error:
	execution_context.errors = [error]
	return ExecutionResult(
	data=None,
	errors=[error],
	extensions=extensions_runner.get_extensions_results_sync(),
	)

	except Exception as error: # pragma: no cover
	error = GraphQLError(str(error), original_error=error)

	execution_context.errors = [error]
	return ExecutionResult(
	data=None,
	errors=[error],
	extensions=extensions_runner.get_extensions_results_sync(),
	)

Strawberry GraphQL/strawberry

Parsing errors are not handled gracefully when ParserCache is used

How does funding with Polar work?

Backer

Why does "Fund on completion" require GitHub login?

When is the invoice due for "Fund on completion"?

What happens if the issue is never completed?

Do I get any extra benefits by funding?

Do I get progress updates?

Contributor

Do I get a reward?

Is rewards guaranteed?

Maintainer

How can I get funding like this for my open source initiatives?