Describe the Bug
I believe I have found multiple issues with window pagination implementation.
AttributeErroris always thrown inListConnectionWithTotalCount.resolve_connection_from_cache- backup solution in case of
AttributeErrorprevents pagination - order and thus pagination itself is non-deterministic when explicit order is not used
- usage of
lastreturns everything and bypassesmax_results
System Information
- Operating system: linux
- Strawberry version (if applicable): 0.47.1
- Database version: 10.11.6-MariaDB
Additional Context
ListConnectionWithTotalCount.resolve_connection_from_cache
AttributeError is always thrown here:
strawberry-django/strawberry_django/relay.py
Line 195 in d6051db
I think there should be something like this?
has_next_page = result[-1]._strawberry_row_number < result[-1]._strawberry_total_count if result else FalseBackup solution in case of AttributeError prevents pagination
This might be intended behavior, but:
In case of AttributeError pagination falls back to resolve_connection but (probably due to unavailable overfetch?) pageInfo's hasNextPage is wrongly reporting as false
Order and thus pagination itself is non-deterministic when explicit order is not used
This is probably the biggest issue. Maybe fixable via pk ordering in case of empty order_by in apply_window_pagination ?
Usage of last returns everything and bypasses max_results
When last is used on it's own and execution ends up here:
strawberry-django/strawberry_django/optimizer.py
Lines 561 to 573 in d6051db
slice_metadata.start is evaluated to 0
slice_metadata.end becomes sys.maxsize
and queryset ends up filtering out nothing
How does funding with Polar work?
Pay now to fund the work behind this issue.
Get updates on progress being made.
Maintainer is rewarded once the issue is completed.
Backer
You're funding impactful open source efforts
Contributor
You want to contribute to this effort
Maintainer
You want to get funding like this too