As I test in latest installation of ora, pressing enter creates a new line and duplicates a progress line, which gives impression that discard of stdin is not effective.
As I investigated it stopped working after #163 was taken.
Additional logical issues I've spotted in codebase:
ourEmitlooks as dead code. this function seem to be never used (do I miss something?)SINGINThandling condition seems logically incorrect, however it's not an issue, asoraloadingsignal-exit(through its dependencies) ensures there's always some listener toSIGINTevent attached. Nonetheless condition should start withif (process.listenerCount('SIGINT')) {and notif (process.listenerCount('SIGINT') === 0) {
I'm not proposing a PR, as I'm not sure how conversion to bl should be handled (whether implementation should stick to it, but fix its setup, or revert to mute-stream where it worked)
/cc @aminya @stroncium
sindresorhus / ora
Elegant terminal spinner
9.1k
How does funding with Polar work?
1
Pay now to fund the work behind this issue.
2
Get updates on progress being made.
3
Maintainer is rewarded once the issue is completed.
FAQ
Backer
You're funding impactful open source efforts
Contributor
You want to contribute to this effort
Maintainer
You want to get funding like this too