Sindre Sorhus/normalize-url

sortQueryParameters buggy handling of search parameters

#189

@nomagick

5 months ago

👍

normalize-url/index.js

Lines 245 to 248 in 4869023

    
           // Calling `.sort()` encodes the search parameters, so we need to decode them again. 
        
           try { 
        
           	urlObject.search = decodeURIComponent(urlObject.search); 
        
           } catch {}

When the query string contains %2F or / like in some S3 signed token, the extra decodeURIComponent breaks the URL.

sindresorhus / normalize-url

Normalize a URL

840

How does funding with Polar work?

Pay now to fund the work behind this issue.

Get updates on progress being made.

Maintainer is rewarded once the issue is completed.

FAQ

Backer

You're funding impactful open source efforts

Contributor

You want to contribute to this effort

Maintainer

You want to get funding like this too

	// Calling `.sort()` encodes the search parameters, so we need to decode them again.
	try {
	urlObject.search = decodeURIComponent(urlObject.search);
	} catch {}

Sindre Sorhus/normalize-url

sortQueryParameters buggy handling of search parameters

How does funding with Polar work?

Backer

Why does "Fund on completion" require GitHub login?

When is the invoice due for "Fund on completion"?

What happens if the issue is never completed?

Do I get any extra benefits by funding?

Do I get progress updates?

Contributor

Do I get a reward?

Is rewards guaranteed?

Maintainer

How can I get funding like this for my open source initiatives?