While this reads fine:
const addOneListener = memoize(addListener, {
cacheKey: arguments_ => arguments_,
cache: new ManyKeysMap()
});This is bad practice:
const addOneListener = memoize(() => {
// some
// inline
// long
// function
// which
// is not
// uncommon
return stuff
}), {
cacheKey: arguments_ => arguments_,
cache: new ManyKeysMap()
});This could be enforced by a linter, since APIs like addEventListener(string, cb, options) exist natively, but ideally memoize and p-memoize should accept a single parameter:
function memoize(details: Callback | Options) {
const {callback, ...options} = typeof details === 'function' ? {callback: details} : details;
}It complicates types a bit but it requires the much cleaner:
const addOneListener = memoize({
cacheKey: arguments_ => arguments_,
cache: new ManyKeysMap(),
callback: () => {
// some
// inline
// long
// function
// which
// is not
// uncommon
return stuff
}),
});Personal note: I went through this recently in webext-storage-cache, changing (fn, opts) => {} to (fnOrOpts) => {}
sindresorhus / memoize
Memoize functions - an optimization technique used to speed up consecutive function calls by caching the result of calls with identical input
1.1k
How does funding with Polar work?
1
Pay now to fund the work behind this issue.
2
Get updates on progress being made.
3
Maintainer is rewarded once the issue is completed.
FAQ
Backer
You're funding impactful open source efforts
Contributor
You want to contribute to this effort
Maintainer
You want to get funding like this too