Stream report downloadProgress when redirects
Describe the bug
In got.stream, downloadProgress fired when redirects happens. Every time redirect happens, the progress report from 0 (with total of content-length, undefined if not any) to 1 instantly (with total of 0). Related issue: electron/fiddle-core#59
- Node.js version: v20.10.0
- OS & version: Windows 11 23H2 (22631.3296)
Actual behavior
downloadProgress triggered every time redirect happens. This makes the progress percent from 0 to 1 and repeat until response.
Expected behavior
downloadProgress should report when it only receive a proper response, not redirect.
Code to reproduce
const { default: got } = require("got");
const dSteram = got.stream('https://github.com/electron/electron/releases/download/v29.1.5/electron-v29.1.5-win32-x64.zip');
dSteram.on('request', (req) => console.log("\n\nREQUEST ===========================", req.path));
dSteram.on('redirect', (req, resp) => {
console.log('====== REDIRECT ======');
console.log('FROM: ', req.url);
console.log('TO: ', resp.url.href);
});
dSteram.on('response', (response) => {
console.log('======= RESPONSE =======');
console.log('URL: ', response.url);
});
dSteram.on('downloadProgress', (progress) => {
console.log('====== PROGRESS ======');
console.log(progress);
});Checklist
- I have read the documentation.
- I have tried my code with the latest version of Node.js and Got.
sindresorhus / got
🌐 Human-friendly and powerful HTTP request library for Node.js
14.3k
How does funding with Polar work?
1
Pay now to fund the work behind this issue.
2
Get updates on progress being made.
3
Maintainer is rewarded once the issue is completed.
FAQ
Backer
You're funding impactful open source efforts
Contributor
You want to contribute to this effort
Maintainer
You want to get funding like this too