prefer-object-from-entries: bad autofix if reduce has a type parameter
If an explicit type parameter is present on reduce, it's unsafe for prefer-object-from-entries to fix the problem because this type parameter will carry over to map which will likely be incompatible:
array.reduce<Record<string, Data & { b?: string }>>(
(res, entry) => ({ ...res, [entry.id]: entry.data }),
{}
);
// is transformed by the rule to ...
// but this type parameter v is wrong for `map`
Object.fromEntries(array.map<Record<string, Data & { b?: string }>>(
( entry) => [entry.id, entry.data]
));Full reproduction: https://stackblitz.com/edit/vitejs-vite-axdfht2u
sindresorhus / eslint-plugin-unicorn
More than 100 powerful ESLint rules
4.3k
How does funding with Polar work?
1
Pay now to fund the work behind this issue.
2
Get updates on progress being made.
3
Maintainer is rewarded once the issue is completed.
FAQ
Backer
You're funding impactful open source efforts
Contributor
You want to contribute to this effort
Maintainer
You want to get funding like this too