prefer-dom-node-append: Property 'append' does not exist on type 'ChildNode'.
Description
Code using appendChild on a Node should not be autofixed to use append. I think this can be improved by using type information and only raising an issue when (or at the very least not autofixing unless) it is known to be an Element.
This relates to #347
Fail
These are currently working fine and should still work
const foo = (element: Element, htmlElement: HTMLElement) => {
element.appendChild(node)
htmlElement.appendChild(node)
}document.getElementsByName("name")[0]?.appendChild(document.createTextNode("foo"))Pass
const foo = (node: Node, childNode: ChildNode, untyped, element: Element) => {
node.appendChild(node) // Current false positive
childNode.appendChild(node) // Current false positive
childNode.appendChild(node) // Current false positive
element.append(node)
}document.body.childNodes[0]?.appendChild(document.createTextNode("foo")) // Current false positiveAdditional Info
These examples are oversimplified just to get the right type.
sindresorhus / eslint-plugin-unicorn
More than 100 powerful ESLint rules
4.2k
How does funding with Polar work?
1
Pay now to fund the work behind this issue.
2
Get updates on progress being made.
3
Maintainer is rewarded once the issue is completed.
FAQ
Backer
You're funding impactful open source efforts
Contributor
You want to contribute to this effort
Maintainer
You want to get funding like this too