Rule proposal: prefer-split-limit
Description
Whenever we use String.prototype.split with literals like so:
string.split('/')[0]
// or
string.split('/')[1]
// or
string.split('/')[2]We benefit by limiting the search space, this allows split to exit early once it attains the number of splits and to not scan the whole string:
string.split('/', 1)[0]
// and
string.split('/', 2)[1]
// and
string.split('/', 3)[2]
// Once we get to the element we want, .split exits early (faster)Fail
string.split('/')[0]
string.split('/').at(0)Pass
string.split('/', 1)[0]
string.split('/', 1).at(0)
string.split('/').at(-1)
string.split('/').at(numberVar)
string.split('/')[numberVar]Proposed rule name
specify-split-limit or prefer-split-limit
Additional Info
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/split#limit
sindresorhus / eslint-plugin-unicorn
More than 100 powerful ESLint rules
4.2k
How does funding with Polar work?
1
Pay now to fund the work behind this issue.
2
Get updates on progress being made.
3
Maintainer is rewarded once the issue is completed.
FAQ
Backer
You're funding impactful open source efforts
Contributor
You want to contribute to this effort
Maintainer
You want to get funding like this too