Fund: Let's change the utils `isBooleanNode(node)` to `isInControlFlow(node)`

Let's change the utils isBooleanNode(node) to isInControlFlow(node)

2 months ago

👍

eslint-plugin-unicorn/rules/utils/boolean.js

Lines 26 to 37 in d3e4b80

    
           /** 
        
           Check if the value of node is a `boolean`. 
        
           @param {Node} node 
        
           @returns {boolean} 
        
           */ 
        
           function isBooleanNode(node) { 
        
           	if ( 
        
           		isLogicNot(node) 
        
           		|| isLogicNotArgument(node) 
        
           		|| isBooleanCall(node) 
        
           		|| isBooleanCallArgument(node)

Currently, this function is too complicated, judging both the node itself and the node's parent.

It is easy to false positives (#1840). Let's split this into two functions

isBooleanExpression(node) - Implemented
isInControlFlow(node) - create a new function

Sindre Sorhus/eslint-plugin-unicorn

Let's change the utils isBooleanNode(node) to isInControlFlow(node)

How does funding with Polar work?

Backer

Contributor

Maintainer

	/**
	Check if the value of node is a `boolean`.

	@param {Node} node
	@returns {boolean}
	*/
	function isBooleanNode(node) {
	if (
	isLogicNot(node)
	\|\| isLogicNotArgument(node)
	\|\| isBooleanCall(node)
	\|\| isBooleanCallArgument(node)

Sindre Sorhus/eslint-plugin-unicorn

Let's change the utils isBooleanNode(node) to isInControlFlow(node)

How does funding with Polar work?

Backer

Why does "Fund on completion" require GitHub login?

When is the invoice due for "Fund on completion"?

What happens if the issue is never completed?

Do I get any extra benefits by funding?

Do I get progress updates?

Contributor

Do I get a reward?

Is rewards guaranteed?

Maintainer

How can I get funding like this for my open source initiatives?