Description
Initially reported in sindresorhus/memoize#97, it's bad practice to place arguments after functions because functions tend to be inlined and eclipse the parameters that follow them.
This could actually be two rules:
- don't allow calling
foo(() => {}, {something: true}) - don't allow declaring
function foo(cb, options) {}
@sindresorhus doesn't like the latter so I'll focus on the first part 😅
Fail
element.addEventListener('click', () => {
// long
}, {once: true})const memoized = memoize(() => {
// long
}, {
cache: new WeakMap(),
})Pass
element.addEventListener('click', () => {
// long
}) // No follow-up argumentconst memoized = memoize(() => {
// long
}) // No follow-up argumentconst handler = () => {
// long
};
element.addEventListener('click', handler, {once: true})const raw = () => {
// long
};
const memoized = memoize(raw, {
cache: new WeakMap(),
}){maxStatements: 3}
element.addEventListener('click', () => short(), {once: true})const memoized = memoize((x) => alert(x), {
cache: new WeakMap(),
})Additional info
This might conflict with https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-array-callback-reference.md in some cases (reduce) if maxStatements defaults to 0
const foo = array.reduce(callback, 0);
// ❌ no-array-callback-reference👇
const foo = array.reduce((a, b) => a + b, 0);
// ❌ no-inline-function-sometimes
sindresorhus / eslint-plugin-unicorn
More than 100 powerful ESLint rules
4.2k
How does funding with Polar work?
1
Pay now to fund the work behind this issue.
2
Get updates on progress being made.
3
Maintainer is rewarded once the issue is completed.
FAQ
Backer
You're funding impactful open source efforts
Contributor
You want to contribute to this effort
Maintainer
You want to get funding like this too