Setup:
- TypeScript
- eslint + no-for-loop
I use the no-for-loop rule to auto fix my code. My code iterates through a string value. The autofix changes my code wrong and assumes that my string is an object.
Original Code
function renderAnimatedChars(formattedValue: string): void {
for (let i = 0; i < formattedValue.length; i++) {
const char = formattedValue[i];
console.log(`Key: ${i} Value: ${char}`);
}
}Code after autofix
function renderAnimatedChars(formattedValue: string): void {
for (const [i, char] of formattedValue.entries()) {
console.log(`Key: ${i} Value: ${char}`);
}
}The problem is that entries is not a valid function on a string. TS2239
An interesting observation is, that this appears only when the type definition is given by the function parameter.
The autofix works correctly if a const parameter is used. The autofix does not change this code.
Original Code
function foo(): void {
const formattedValue = 'bla bla';
for (let i = 0; i < formattedValue.length; i++) {
const char = formattedValue[i];
console.log(`Key: ${i} Value: ${char}`);
}
}
sindresorhus / eslint-plugin-unicorn
More than 100 powerful ESLint rules
4.2k
How does funding with Polar work?
1
Pay now to fund the work behind this issue.
2
Get updates on progress being made.
3
Maintainer is rewarded once the issue is completed.
FAQ
Backer
You're funding impactful open source efforts
Contributor
You want to contribute to this effort
Maintainer
You want to get funding like this too