Rule proposal: no-identical-catch
Description
Same catch statement inside another catch statement can be safely removed
Fail
try {
if (foo) {
try {
for await (const result of value) {
handleResponse(result);
}
setIsFetching(false);
setSubscription(null);
} catch (error) {
setIsFetching(false); // ❌ duplicates can be safely removed
setResponse(formatError(error)); // ❌ duplicates can be safely removed
setSubscription(null); // ❌ duplicates can be safely removed
}
} else {
handleResponse(value);
}
} catch (error) {
setIsFetching(false);
setResponse(formatError(error));
setSubscription(null);
}Pass
try {
if (foo) {
try {
for await (const result of value) {
handleResponse(result);
}
setIsFetching(false);
setSubscription(null);
} catch (error) {
setIsFetching(false);
setResponse(someAnotherFunction(error));
setSubscription(null);
}
} else {
handleResponse(value);
}
} catch (error) {
setIsFetching(false);
setResponse(formatError(error));
setSubscription(null);
}Additional Info
real-world example graphql/graphiql#3033
sindresorhus / eslint-plugin-unicorn
More than 100 powerful ESLint rules
4.2k
How does funding with Polar work?
1
Pay now to fund the work behind this issue.
2
Get updates on progress being made.
3
Maintainer is rewarded once the issue is completed.
FAQ
Backer
You're funding impactful open source efforts
Contributor
You want to contribute to this effort
Maintainer
You want to get funding like this too