Rule proposal: prefer-immediate-return
In my opinion it’s never desirable to assign a value to a variable, only to be returned immediately. I believe this is often the leftover result of debugging.
In other words, if a value is declared, and returned immediately in the next statement, the two should be merged, removing the useless variable.
Fail
// A
function foo() {
const result = bar();
return result;
}// B
function foo() {
let result;
return result;
}Pass
function foo() {
const result = bar();
// Anything in between is allowed.
console.log(result);
return result;
}function foo() {
let result;
result = bar();
return result;
}// Autofix result for A
function foo() {
return bar();
}// Autofix result for B
function foo() {
return;
}
sindresorhus / eslint-plugin-unicorn
More than 100 powerful ESLint rules
4.2k
How does funding with Polar work?
1
Pay now to fund the work behind this issue.
2
Get updates on progress being made.
3
Maintainer is rewarded once the issue is completed.
FAQ
Backer
You're funding impactful open source efforts
Contributor
You want to contribute to this effort
Maintainer
You want to get funding like this too