I've seen many people just write the compare function too complicated, yes sometimes maybe it's more readable, but sometimes it's just too long.
Fail
array.sort((a, b) => {
if (a > b) {
return 1;
}
if (a < b) {
return -1;
}
return 0;
});array.sort((a, b) => a > b ? 1 : -1);array.sort((a, b) => {
if (a.foo > b.foo) {
return 1;
}
if (a.foo < b.foo) {
return -1;
}
if (a.bar > b.bar) {
return 1;
}
if (a.bar < b.bar) {
return -1;
}
return 0;
});array.sort(() => Math.random() > 0. 5 ? 1 : -1);Pass
array.sort((a, b) => a - b);array.sort((a, b) => a.localeCompare(b));array.sort((a, b) => a.foo - b.foo || a.bar - b.bar);array.sort(() => Math.random() - 0.5);This rule should not fixable unless we are sure they are numbers.
sindresorhus / eslint-plugin-unicorn
More than 100 powerful ESLint rules
4.2k
How does funding with Polar work?
1
Pay now to fund the work behind this issue.
2
Get updates on progress being made.
3
Maintainer is rewarded once the issue is completed.
FAQ
Backer
You're funding impactful open source efforts
Contributor
You want to contribute to this effort
Maintainer
You want to get funding like this too