Fund: Rule proposal: `no-break-in-nested-loop`

Rule proposal: no-break-in-nested-loop

4 years ago

👍

Actually, getting this because of auto-fix for no-array-for-each rule, it fix return in nested .forEach to continue.

It's not clear what to break/continue, when loop is nested.

Fail

for (const foo of bar) {
	for (const baz of foo) {
		// ...
		break;
	}
}

for (const foo of bar) {
	while(foo.pop()) {
		// ...
		continue;
	}
}

A even confusing case

for (const foo of bar) {
	switch (foo) {
		case 1:
			// ...
			break;
		case 2:
			// ...
			continue;
	}
}

function processFoo() {
	for (const baz of foo) {
		// ...
		break;
	}
}

for (const foo of bar) {
	processFoo(foo)
}