Explain why it's not a singleton
It's easy to think that it would make for a simpler API. No need to initialize it first. I thought so too at first.
But imagine if it had been a singleton:
index.js
const config = require('electron-config');
const someComponent = require('./some-component');
config.setDefaults({
foo: true
});
…
config.get('foo');
//=> truesome-component.js
const config = require('electron-config');
…
config.get('foo');
//=> undefinedNote the undefined. So you would have to be careful about setting the defaults before any app imports, which is easy to forget.
The following a much safer and explicit pattern:
config.js
const config = require('electron-config');
module.exports = new Config({
foo: true
});index.js
const config = require('./config');
const someComponent = require('./some-component');
…
config.get('foo');
//=> truesome-component.js
const config = require('./config');
…
config.get('foo');
//=> trueThoughts on this?
sindresorhus / electron-store
Simple data persistence for your Electron app or module - Save and load user preferences, app state, cache, etc
4.7k
How does funding with Polar work?
1
Pay now to fund the work behind this issue.
2
Get updates on progress being made.
3
Maintainer is rewarded once the issue is completed.
FAQ
Backer
You're funding impactful open source efforts
Contributor
You want to contribute to this effort
Maintainer
You want to get funding like this too