Incorrect Typescript types for defaultActions
Typescript actions defined as
interface Actions {
readonly separator: () => MenuItemConstructorOptions;
readonly learnSpelling: (options: ActionOptions) => MenuItemConstructorOptions;
readonly lookUpSelection: (options: ActionOptions) => MenuItemConstructorOptions;
readonly searchWithGoogle: (options: ActionOptions) => MenuItemConstructorOptions;
readonly cut: (options: ActionOptions) => MenuItemConstructorOptions;
readonly copy: (options: ActionOptions) => MenuItemConstructorOptions;
readonly paste: (options: ActionOptions) => MenuItemConstructorOptions;
readonly saveImage: (options: ActionOptions) => MenuItemConstructorOptions;
readonly saveImageAs: (options: ActionOptions) => MenuItemConstructorOptions;
readonly copyLink: (options: ActionOptions) => MenuItemConstructorOptions;
readonly copyImage: (options: ActionOptions) => MenuItemConstructorOptions;
readonly copyImageAddress: (options: ActionOptions) => MenuItemConstructorOptions;
readonly inspect: () => MenuItemConstructorOptions;
readonly services: () => MenuItemConstructorOptions;
}But in fact, the options argument has a default value. All actions should be defiend as:
interface Actions {
readonly separator: () => MenuItemConstructorOptions;
readonly learnSpelling: (options?: ActionOptions) => MenuItemConstructorOptions;
readonly lookUpSelection: (options?: ActionOptions) => MenuItemConstructorOptions;
readonly searchWithGoogle: (options?: ActionOptions) => MenuItemConstructorOptions;
readonly cut: (options?: ActionOptions) => MenuItemConstructorOptions;
readonly copy: (options?: ActionOptions) => MenuItemConstructorOptions;
readonly paste: (options?: ActionOptions) => MenuItemConstructorOptions;
readonly saveImage: (options?: ActionOptions) => MenuItemConstructorOptions;
readonly saveImageAs: (options?: ActionOptions) => MenuItemConstructorOptions;
readonly copyLink: (options?: ActionOptions) => MenuItemConstructorOptions;
readonly copyImage: (options?: ActionOptions) => MenuItemConstructorOptions;
readonly copyImageAddress: (options?: ActionOptions) => MenuItemConstructorOptions;
readonly inspect: () => MenuItemConstructorOptions;
readonly services: () => MenuItemConstructorOptions;
}
sindresorhus / electron-context-menu
Context menu for your Electron app
1.4k
How does funding with Polar work?
1
Pay now to fund the work behind this issue.
2
Get updates on progress being made.
3
Maintainer is rewarded once the issue is completed.
FAQ
Backer
You're funding impactful open source efforts
Contributor
You want to contribute to this effort
Maintainer
You want to get funding like this too