onDidChange doesn't support dot-notation for nested properties
I get a typescript compilation error when I try to pass in a key with dot-notation to the onDidChange method. This seems to happen because the type of key the onDidChange method is expecting is keyof <StoreType>. This doesn't include the nested object properties.
Requesting to add an overload that takes a key of type string. Just like the get or set.
Thanks!
interface Config {
foo: Foo;
};
interface Foo {
bar: string;
};
export const defaults: Config = {
foo: {
bar: "foobar"
}
};
const store = new Store<Config>({
defaults,
});
// ERROR - Argument of type '"foo.bar"' is not assignable to parameter of type 'keyof Config'.
store.onDidChange('foo.bar', (nVal, oVal) => {
console.log(nVal, oVal);
});
sindresorhus / conf
Simple config handling for your app or module
1.2k
How does funding with Polar work?
1
Pay now to fund the work behind this issue.
2
Get updates on progress being made.
3
Maintainer is rewarded once the issue is completed.
FAQ
Backer
You're funding impactful open source efforts
Contributor
You want to contribute to this effort
Maintainer
You want to get funding like this too