At the moment we don't have a good distinction between styles and classificator (OSM tags matching) flows, changes to both are processed via generate_drules.sh
and related tests are mixed up as well.
At the moment there is no consistency where which checks are implemented and when they're triggered.
On every generate_drules.sh
run:
Manual test runs and automatic GH CI runs (e.g. every push to a PR), need up-to-date tests binaries and sometimes long-running:
map/style_tests/classificator_tests.cpp
- relative types priorities and some other checks
map/style_tests/dashes_test.cpp
- format and limits of dashes declarations
map/style_tests/style_symbols_consistency_test.cpp
- consistency with symbols/icons skins
generator/generator_tests/osm_type_test.cpp
- OSM tags to OM types matching
generator/generator_tests/tag_admixer_test.cpp
- replacement_tags.txt
indexer/indexer_tests/feature_types_test.cpp
- types sorting? and "useless" types
indexer/indexer_tests/visibility_test.cpp
- some min/max zoom checking??
Missing (or not really visible/used) related checks:
Let's think how to make it more consistent and helpful in early validation issues detection (before the changes are pushed to the repo).
A part of
Pay now to fund the work behind this issue.
Get updates on progress being made.
Maintainer is rewarded once the issue is completed.
You're funding impactful open source efforts
You want to contribute to this effort
You want to get funding like this too