Routing open-hours tests are failing in different timezones
TZ='America/Argentina/Buenos_Aires' ../omim-build-debug/routing_tests works, while
TZ='Europe/Paris' ../omim-build-debug/routing_tests fails:
Running opening_hours_serdes_tests.cpp::OHSerDesTestFixture_OpeningHoursSerDes_Weekday_Usage_2
FAILED
routing_tests/opening_hours_serdes_tests.cpp:749 TEST(oh.IsOpen(GetUnixtimeByDate(2023, Month::Apr, Weekday::Saturday, 13 , 30 )))
Running opening_hours_serdes_tests.cpp::OHSerDesTestFixture_OpeningHoursSerDes_MonthHours_Usage
FAILED
routing_tests/opening_hours_serdes_tests.cpp:822 TEST(oh.IsClosed(GetUnixtimeByDate(2020, Month::May, 6, 01 , 00 )))
Running road_access_test.cpp::RoadAccess_WayBlockedWhenStartButOpenWhenReach
FAILED
routing_tests/index_graph_tools.cpp:608 TEST(base::AlmostEqualAbs(pathWeight, expectedWeight, kEpsilon)) 10804 12802 [5: (0, 1) (1, 2) (2, 3) (3, 4) (4, 5) ]
Opening hours/times in OpenStreetMap are specified in the local time zone. Tests (and production code!) should be robust to work properly with any local timezone specified.
organicmaps / organicmaps
🍃 Organic Maps is a free Android & iOS offline maps app for travelers, tourists, hikers, and cyclists. It uses crowd-sourced OpenStreetMap data and is developed with love by MapsWithMe (MapsMe) founders and our community. No ads, no tracking, no data collection, no crapware. Please donate to support the development!
9.8k
How does funding with Polar work?
1
Pay now to fund the work behind this issue.
2
Get updates on progress being made.
3
Maintainer is rewarded once the issue is completed.
FAQ
Backer
You're funding impactful open source efforts
Contributor
You want to contribute to this effort
Maintainer
You want to get funding like this too