Fund: Bug: cookie string parsing incorrectly handles attributes without values

Description

The parse_cookie_string() function incorrectly handles attributes without values and will keep only one due to the dictionary conversion.
For example if the cookie contains the HttpOnly and the Secure attributes these will both have an empty string as key and eventually only one of these will be returned.

URL to code causing the issue

litestar/litestar/_parsers.py

Lines 50 to 67 in 3dfd6fe

    
           def parse_cookie_string(cookie_string: str) -> dict[str, str]: 
        
               """Parse a cookie string into a dictionary of values. 
        
               Args: 
        
                   cookie_string: A cookie string. 
        
               Returns: 
        
                   A string keyed dictionary of values 
        
               """ 
        
               cookies = [cookie.split("=", 1) if "=" in cookie else ("", cookie) for cookie in cookie_string.split(";")] 
        
               output: dict[str, str] = { 
        
                   k: unquote(unquote_cookie(v)) 
        
                   for k, v in filter( 
        
                       lambda x: x[0] or x[1], 
        
                       ((k.strip(), v.strip()) for k, v in cookies), 
        
                   ) 
        
               } 
        
               return output

MCVE

No response

Steps to reproduce

No response

Screenshots

No response

Logs

No response

Litestar Version

v2.5.1

Platform

Linux
Mac
Windows
Other (Please specify in the description above)

Litestar/litestar

Bug: cookie string parsing incorrectly handles attributes without values

Description

URL to code causing the issue

MCVE

Steps to reproduce

Screenshots

Logs

Litestar Version

Platform

How does funding with Polar work?

Backer

Contributor

Maintainer

	def parse_cookie_string(cookie_string: str) -> dict[str, str]:
	"""Parse a cookie string into a dictionary of values.

	Args:
	cookie_string: A cookie string.

	Returns:
	A string keyed dictionary of values
	"""
	cookies = [cookie.split("=", 1) if "=" in cookie else ("", cookie) for cookie in cookie_string.split(";")]
	output: dict[str, str] = {
	k: unquote(unquote_cookie(v))
	for k, v in filter(
	lambda x: x[0] or x[1],
	((k.strip(), v.strip()) for k, v in cookies),
	)
	}
	return output

Litestar/litestar

Bug: cookie string parsing incorrectly handles attributes without values

Description

URL to code causing the issue

MCVE

Steps to reproduce

Screenshots

Logs

Litestar Version

Platform

How does funding with Polar work?

Backer

Why does "Fund on completion" require GitHub login?

When is the invoice due for "Fund on completion"?

What happens if the issue is never completed?

Do I get any extra benefits by funding?

Do I get progress updates?

Contributor

Do I get a reward?

Is rewards guaranteed?

Maintainer

How can I get funding like this for my open source initiatives?