Package

filament/filament

Package Version

v3.2

Laravel Version

v11

Livewire Version

No response

PHP Version

8.2

Problem description

While preparing a video based on the official filament demo, noticed two queries running for the badge:

Debugged a bit deeper and discovered that the whole menu is being loaded twice.

Confirmed that I'm not alone, by two discussions opened by the same person:

• https://github.com/filamentphp/filament/discussions/10285
• https://github.com/filamentphp/filament/discussions/10204

But those discussions didn't lead to any issues opened, at least I haven't found, so creating one.

Made a bit of a source-dive. Managed to locate the problem but didn't manage to fix it.

Discovered that new NavigationManager() is called twice: https://github.com/search?q=repo%3Afilamentphp%2Ffilament%20new%20NavigationManager&type=code

• In FilamentServiceProvider
• And in HasRoutes concern

There seems to be a check to prevent double-loading but for some reason it doesn't trigger for me:

if (! $this->isNavigationMounted) {
    $this->mountNavigation();
}

P.S. Interesting part: during my testing, seems that the Cluster part of the menu (Products + Categories + Brands) is loaded only once, not twice. So there's some separate different logic for clusters, probably.

Expected behavior

There should be one SQL query: either by not duplicating the query, or not duplicating the navigation manager call.

Steps to reproduce

Just load the official demo locally and load any page with Laravel Debugbar and see the queries

Reproduction repository (issue will be closed if this is not valid)

https://github.com/filamentphp/demo

Relevant log output

No response