App
first in README / Docs intro.app = App()
style, but then go on to demonstrate plain ASGI style example, and discuss design philosophy of "everything is just ASGI" , interoperable, eg. use TestClient
with Channels.WebSocketSession
as just WebSocket
? Rename session
variable as websocket
in docs?StaticFile
, and just leave StaticFiles
and FileResponse
.starlette.requests
/starlette.responses
instead of starlette.request
/starlette.response
? Would fit websockets
and align better with documentation titles.App
should perhaps be Starlette
instead. Less likely to be confused with plain ASGI App
class examples, and mirrors eg. flask.Flask
and sanic.Sanic
.HTTPEndpoint
and WebSocketEndpoint
?Ensure that requests
is only required if TestClient
is used. Ensure that aiofiles
is only required if FileResponse
/StaticFiles
is used. We could choose to push FileResponse
into the starlette.staticfiles
module, and only ever import aiofiles
from there.
See https://github.com/encode/starlette/milestone/1
Pay now to fund the work behind this issue.
Get updates on progress being made.
Maintainer is rewarded once the issue is completed.
You're funding impactful open source efforts
You want to contribute to this effort
You want to get funding like this too