1.91.1
2.3.0
1.8.3
biome's config file is not respected when it comes to lint quick fixes:
{
"$schema": "./node_modules/@biomejs/biome/configuration_schema.json",
"vcs": {
"enabled": true,
"clientKind": "git",
"defaultBranch": "main",
"useIgnoreFile": true
},
"organizeImports": {
"enabled": true
},
"formatter": {
"enabled": true,
"formatWithErrors": true,
"indentWidth": 2,
"lineWidth": 110,
"ignore": ["package.json", ".ts", ".sst", "cdk.context.json"]
},
"linter": {
"enabled": false
},
"javascript": {
"formatter": {
"quoteStyle": "single"
}
},
"overrides": [
{
"include": ["extensions.json", "tsconfig.shared.json"],
"json": { "parser": { "allowComments": true } }
}
]
}
My oxlint is detecting an issue and showing it to me, but biome is showing a quick fix that wouldn't even work as the linter is disabled.
no-empty-pattern
Biome checks whether the linter is even enabled before providing linting suggestions
No
[CodeAction(CodeAction { title: "Suppress rule lint/correctness/noEmptyPattern", kind: Some(CodeActionKind("quickfix.suppressRule.biome.correctness.noEmptyPattern")), diagnostics: None, edit: Some(WorkspaceEdit { changes: Some({Url { scheme: "file", cannot_be_a_base: false, username: "", password: None, host: None, port: None, path: "/Users/omni/git/payment-sst/packages/services/core/user/user-service.test.ts", query: None, fragment: None }: [TextEdit { range: Range { start: Position { line: 30, character: 1 }, end: Position { line: 30, character: 1 } }, new_text: "// biome-ignore lint/correctness/noEmptyPattern: <explanation>\n\t" }]}), document_changes: None, change_annotations: None }), command: None, is_preferred: None, disabled: None, data: None })]
βββ
βββbiome_lsp::handlers::analysis::code_actions{uri=file:///Users/omni/git/payment-sst/packages/services/core/user/user-service.test.ts, range=Range { start: Position { line: 30, character: 13 }, end: Position { line: 30, character: 15 } }, only=Some([CodeActionKind("quickfix")]), diagnostics=[Diagnostic { range: Range { start: Position { line: 30, character: 13 }, end: Position { line: 30, character: 15 } }, severity: Some(Warning), code: None, code_description: None, source: Some("oxc"), message: "eslint(no-empty-pattern): Disallow empty destructuring patterns.\nhelp: Passing `null` or `undefined` will result in runtime error because `null` and `undefined` cannot be destructured.", related_information: Some([DiagnosticRelatedInformation { location: Location { uri: Url { scheme: "file", cannot_be_a_base: false, username: "", password: None, host: None, port: None, path: "/Users/omni/git/payment-sst/packages/services/core/user/user-service.test.ts", query: None, fragment: None }, range: Range { start: Position { line: 30, character: 13 }, end: Position { line: 30, character: 15 } } }, message: "Empty object binding pattern" }]), tags: None, data: None }]}
ββ 0ms DEBUG biome_service::workspace::server File capabilities: Js(JsFileSource { language: TypeScript { definition_file: false }, variant: Standard, module_kind: Module, version: ES2022, embedding_kind: None }) BiomePath { path: "/Users/omni/git/payment-sst/packages/services/core/user/user-service.test.ts" }
ββ 0ms DEBUG biome_service::workspace The file has the following feature sets:
β {Format: Supported, Search: FileNotSupported, Lint: FeatureNotEnabled, OrganizeImports: Supported}
ββ 0ms DEBUG biome_lsp::handlers::analysis Cursor range 943..945
ββ 0ms DEBUG biome_service::workspace::server File capabilities: Js(JsFileSource { language: TypeScript { definition_file: false }, variant: Standard, module_kind: Module, version: ES2022, embedding_kind: None }) BiomePath { path: "/Users/omni/git/payment-sst/packages/services/core/user/user-service.test.ts" }
βββbiome_service::file_handlers::javascript::code_actions{}
βββbiome_service::file_handlers::javascript::Code actions JavaScript{range=943..945, path=BiomePath { path: "/Users/omni/git/payment-sst/packages/services/core/user/user-service.test.ts" }}
Pay now to fund the work behind this issue.
Get updates on progress being made.
Maintainer is rewarded once the issue is completed.
You're funding impactful open source efforts
You want to contribute to this effort
You want to get funding like this too