💅 useExhaustiveDependencies does not correctly capture dependencies from destructured arrays
Environment information
CLI:
Version: 1.8.3
Color support: true
Platform:
CPU Architecture: x86_64
OS: windows
Environment:
BIOME_LOG_DIR: unset
NO_COLOR: unset
TERM: unset
JS_RUNTIME_VERSION: "v21.6.2"
JS_RUNTIME_NAME: "node"
NODE_PACKAGE_MANAGER: "yarn/1.22.21"
Biome Configuration:
Status: Loaded successfully
Formatter disabled: false
Linter disabled: false
Organize imports disabled: false
VCS disabled: false
Linter:
JavaScript enabled: true
JSON enabled: true
CSS enabled: true
Recommended: false
All: true
Enabled rules:
style/useImportType
suspicious/noCatchAssign
complexity/useLiteralKeys
nursery/useThrowOnlyError
suspicious/useNamespaceKeyword
complexity/noMultipleSpacesInRegularExpressionLiterals
complexity/noUselessEmptyExport
suspicious/noAssignInExpressions
nursery/noYodaExpression
suspicious/noDuplicateParameters
correctness/noConstructorReturn
style/useSelfClosingElements
style/useTemplate
correctness/noUnusedLabels
correctness/noUnreachableSuper
suspicious/noCompareNegZero
a11y/noAutofocus
correctness/noUnsafeOptionalChaining
correctness/noConstAssign
nursery/noMisplacedAssertion
suspicious/noControlCharactersInRegex
style/noVar
suspicious/noDoubleEquals
suspicious/noEmptyInterface
suspicious/noConstEnum
nursery/noDuplicateElseIf
correctness/noPrecisionLoss
nursery/noUnknownFunction
correctness/noSetterReturn
correctness/noInvalidConstructorSuper
suspicious/noImplicitAnyLet
a11y/useKeyWithClickEvents
suspicious/noDuplicateObjectKeys
suspicious/noUnsafeDeclarationMerging
correctness/noInnerDeclarations
correctness/useArrayLiterals
style/noUselessElse
complexity/noUselessLabel
complexity/noUselessCatch
a11y/useAriaPropsForRole
style/useCollapsedElseIf
correctness/noNonoctalDecimalEscape
suspicious/noDuplicateTestHooks
complexity/noStaticOnlyClass
a11y/noInteractiveElementToNoninteractiveRole
suspicious/noLabelVar
correctness/noNodejsModules
suspicious/noApproximativeNumericConstant
correctness/noUnnecessaryContinue
nursery/noEmptyBlock
correctness/noEmptyCharacterClassInRegex
suspicious/noSparseArray
a11y/useIframeTitle
nursery/useDefaultSwitchClause
a11y/noSvgWithoutTitle
correctness/noVoidElementsWithChildren
correctness/useJsxKeyInIterable
style/useExportType
complexity/noUselessLoneBlockStatements
style/noArguments
a11y/useValidAriaValues
suspicious/noGlobalAssign
suspicious/noCommentText
suspicious/noThenProperty
suspicious/useGetterReturn
style/useFragmentSyntax
a11y/noPositiveTabindex
style/useNamingConvention
correctness/noRenderReturnValue
correctness/useExhaustiveDependencies
security/noGlobalEval
a11y/noRedundantRoles
correctness/noUnusedVariables
suspicious/noSelfCompare
nursery/useErrorMessage
suspicious/noAsyncPromiseExecutor
security/noDangerouslySetInnerHtml
style/useNodejsImportProtocol
suspicious/noArrayIndexKey
complexity/noWith
suspicious/noDuplicateClassMembers
complexity/noExtraBooleanCast
performance/noAccumulatingSpread
suspicious/noConfusingLabels
correctness/noChildrenProp
nursery/useImportExtensions
a11y/noAriaUnsupportedElements
style/noShoutyConstants
correctness/noFlatMapIdentity
a11y/noBlankTarget
a11y/useHeadingContent
correctness/useValidForDirection
correctness/noInvalidUseBeforeDeclaration
a11y/noAriaHiddenOnFocusable
style/useBlockStatements
correctness/noInvalidNewBuiltin
style/noNegationElse
complexity/useSimplifiedLogicExpression
nursery/useSortedClasses
style/noRestrictedGlobals
style/noNamespaceImport
style/noUnusedTemplateLiteral
correctness/noUndeclaredVariables
style/useExponentiationOperator
suspicious/useAwait
nursery/useAdjacentOverloadSignatures
nursery/noUnknownProperty
style/noNamespace
complexity/noUselessFragments
correctness/noUnusedImports
suspicious/noFunctionAssign
performance/noDelete
suspicious/noUnsafeNegation
a11y/useValidLang
nursery/noUndeclaredDependencies
nursery/noConsole
a11y/useValidAriaRole
correctness/noConstantCondition
a11y/useAriaActivedescendantWithTabindex
suspicious/useValidTypeof
style/useDefaultParameterLast
complexity/noEmptyTypeParameters
complexity/noUselessTernary
suspicious/noExplicitAny
correctness/noSwitchDeclarations
complexity/noUselessTypeConstraint
suspicious/noRedundantUseStrict
style/useLiteralEnumMembers
nursery/noUselessUndefinedInitialization
suspicious/noGlobalIsNan
suspicious/noSkippedTests
suspicious/noMisleadingCharacterClass
nursery/noUnmatchableAnbSelector
nursery/noUnknownSelectorPseudoElement
correctness/noStringCaseMismatch
suspicious/noRedeclare
suspicious/noFallthroughSwitchClause
nursery/useExplicitLengthCheck
complexity/noUselessThisAlias
correctness/noUnreachable
nursery/noUselessStringConcat
complexity/noThisInStatic
complexity/useOptionalChain
suspicious/noDuplicateCase
style/noParameterAssign
nursery/noLabelWithoutControl
a11y/useValidAnchor
complexity/useRegexLiterals
correctness/noSelfAssign
nursery/useThrowNewError
style/useShorthandFunctionType
style/useSingleCaseStatement
nursery/noUnusedFunctionParameters
suspicious/noEmptyBlockStatements
suspicious/noShadowRestrictedNames
a11y/useMediaCaption
correctness/noUnsafeFinally
style/useNodeAssertStrict
style/useEnumInitializers
a11y/useHtmlLang
style/useWhile
complexity/useArrowFunction
style/noInferrableTypes
a11y/noNoninteractiveTabindex
complexity/useSimpleNumberKeys
correctness/useYield
nursery/useTopLevelRegex
style/useNumericLiterals
suspicious/noImportAssign
suspicious/useDefaultSwitchClauseLast
correctness/noGlobalObjectCalls
style/noParameterProperties
a11y/useAltText
nursery/useNumberToFixedDigitsArgument
performance/noBarrelFile
suspicious/noSuspiciousSemicolonInJsx
complexity/noBannedTypes
suspicious/noPrototypeBuiltins
style/useAsConstAssertion
suspicious/noDebugger
suspicious/noMisleadingInstantiator
complexity/noVoid
suspicious/noDuplicateJsxProps
correctness/noEmptyPattern
nursery/noDuplicateJsonKeys
complexity/noExcessiveNestedTestSuites
performance/noReExportAll
a11y/useKeyWithMouseEvents
nursery/useConsistentBuiltinInstantiation
security/noDangerouslySetInnerHtmlWithChildren
suspicious/noExtraNonNullAssertion
style/useConst
style/noNonNullAssertion
complexity/useFlatMap
correctness/useHookAtTopLevel
correctness/useIsNan
suspicious/noGlobalIsFinite
complexity/noExcessiveCognitiveComplexity
a11y/noDistractingElements
nursery/useFocusableInteractive
style/useConsistentArrayType
style/useForOf
a11y/useValidAriaProps
a11y/noRedundantAlt
nursery/useSemanticElements
nursery/useGenericFontNames
suspicious/noConfusingVoidType
suspicious/noFocusedTests
a11y/useButtonType
nursery/useDateNow
style/useFilenamingConvention
style/useShorthandArrayType
style/useShorthandAssign
correctness/noConstantMathMinMaxClamp
correctness/noUnusedPrivateClassMembers
correctness/noVoidTypeReturn
a11y/useAnchorContent
complexity/noUselessRename
style/useNumberNamespace
complexity/noUselessConstructor
a11y/noAccessKey
complexity/noUselessSwitchCase
nursery/noUnknownUnit
style/noDefaultExport
style/useSingleVarDeclarator
suspicious/noExportsInTest
a11y/noNoninteractiveElementToInteractiveRole
style/noCommaOperator
suspicious/useIsArray
a11y/noHeaderScope
correctness/noNewSymbol
suspicious/noMisrefactoredShorthandAssign
complexity/noForEach
suspicious/noClassAssign
nursery/noEvolvingTypesRule name
lint/correctness/useExhaustiveDependencies
Playground link
Expected result
Values from destructured state arrays should be required dependencies.
const [[a, b], setPair] = useState([1, 2]);
useEffect(() => {
console.log(a, b);
}, [a, b]);
Code of Conduct
- I agree to follow Biome's Code of Conduct
biomejs / biome
A toolchain for web projects, aimed to provide functionalities to maintain them. Biome offers formatter and linter, usable via CLI and LSP.
15.0k
Contributors get 70% of received funds after fees
How does funding with Polar work?
1
Pay now to fund the work behind this issue.
2
Get updates on progress being made.
3
Maintainer is rewarded once the issue is completed.
FAQ
Backer
You're funding impactful open source efforts
Contributor
You want to contribute to this effort
Maintainer
You want to get funding like this too