💅 lint/complexity/noForEach should not throw on Effect.forEach (or be configurable)
Environment information
CLI:
Version: 1.8.3
Color support: true
Platform:
CPU Architecture: aarch64
OS: macos
Environment:
BIOME_LOG_DIR: unset
NO_COLOR: unset
TERM: "xterm-kitty"
JS_RUNTIME_VERSION: "v20.12.2"
JS_RUNTIME_NAME: "node"
NODE_PACKAGE_MANAGER: "pnpm/9.4.0"
Biome Configuration:
Status: Loaded successfully
Formatter disabled: false
Linter disabled: false
Organize imports disabled: false
VCS disabled: false
Linter:
JavaScript enabled: true
JSON enabled: true
CSS enabled: true
Recommended: true
All: false
Enabled rules:
performance/noDelete
suspicious/noCatchAssign
suspicious/noUnsafeNegation
complexity/useLiteralKeys
style/useImportType
complexity/noMultipleSpacesInRegularExpressionLiterals
a11y/useValidLang
complexity/noUselessEmptyExport
suspicious/useNamespaceKeyword
suspicious/useValidTypeof
a11y/useValidAriaRole
correctness/noConstantCondition
a11y/useAriaActivedescendantWithTabindex
suspicious/noAssignInExpressions
style/useDefaultParameterLast
complexity/noEmptyTypeParameters
correctness/noConstructorReturn
style/useSelfClosingElements
suspicious/noDuplicateParameters
style/useTemplate
correctness/noUnusedLabels
complexity/noUselessTernary
correctness/noUnreachableSuper
suspicious/noCompareNegZero
suspicious/noExplicitAny
correctness/noSwitchDeclarations
a11y/noAutofocus
correctness/noUnsafeOptionalChaining
correctness/noConstAssign
suspicious/noControlCharactersInRegex
complexity/noUselessTypeConstraint
style/noVar
suspicious/noDoubleEquals
suspicious/noRedundantUseStrict
style/useLiteralEnumMembers
nursery/noUnknownPseudoClassSelector
suspicious/noEmptyInterface
nursery/noInvalidPositionAtImportRule
suspicious/noConstEnum
nursery/noDuplicateElseIf
correctness/noPrecisionLoss
nursery/noUnmatchableAnbSelector
suspicious/noGlobalIsNan
nursery/noUnknownSelectorPseudoElement
correctness/noStringCaseMismatch
nursery/noUnknownFunction
correctness/noSetterReturn
correctness/noInvalidConstructorSuper
suspicious/noImplicitAnyLet
suspicious/noFallthroughSwitchClause
a11y/useKeyWithClickEvents
correctness/noUnreachable
nursery/noImportantInKeyframe
suspicious/noDuplicateObjectKeys
complexity/noUselessThisAlias
complexity/noThisInStatic
complexity/useOptionalChain
correctness/noInnerDeclarations
style/noParameterAssign
suspicious/noDuplicateCase
suspicious/noUnsafeDeclarationMerging
nursery/noLabelWithoutControl
a11y/useValidAnchor
suspicious/noMisleadingCharacterClass
complexity/useRegexLiterals
correctness/noSelfAssign
suspicious/noRedeclare
style/noUselessElse
style/useShorthandFunctionType
suspicious/noShadowRestrictedNames
a11y/useMediaCaption
complexity/noUselessLabel
complexity/noUselessCatch
nursery/noDuplicateFontNames
correctness/noUnsafeFinally
a11y/useAriaPropsForRole
correctness/noNonoctalDecimalEscape
style/useEnumInitializers
a11y/useHtmlLang
suspicious/noDuplicateTestHooks
complexity/noStaticOnlyClass
nursery/noShorthandPropertyOverrides
style/useWhile
complexity/useArrowFunction
style/noInferrableTypes
a11y/noNoninteractiveTabindex
complexity/useSimpleNumberKeys
correctness/useYield
a11y/noInteractiveElementToNoninteractiveRole
nursery/noEmptyBlock
correctness/noUnnecessaryContinue
style/useNumericLiterals
suspicious/noApproximativeNumericConstant
suspicious/noImportAssign
correctness/noGlobalObjectCalls
suspicious/noLabelVar
suspicious/useDefaultSwitchClauseLast
a11y/useAltText
correctness/noEmptyCharacterClassInRegex
suspicious/noSuspiciousSemicolonInJsx
suspicious/noSparseArray
a11y/useIframeTitle
complexity/noBannedTypes
a11y/noSvgWithoutTitle
correctness/noVoidElementsWithChildren
style/useAsConstAssertion
correctness/useJsxKeyInIterable
style/useExportType
complexity/noUselessLoneBlockStatements
style/noArguments
a11y/useValidAriaValues
suspicious/noDebugger
suspicious/noCommentText
suspicious/noGlobalAssign
suspicious/noMisleadingInstantiator
suspicious/noPrototypeBuiltins
suspicious/noDuplicateJsxProps
suspicious/noThenProperty
a11y/noPositiveTabindex
correctness/noEmptyPattern
complexity/noExcessiveNestedTestSuites
nursery/noDuplicateJsonKeys
a11y/useKeyWithMouseEvents
security/noDangerouslySetInnerHtmlWithChildren
suspicious/noExtraNonNullAssertion
correctness/noRenderReturnValue
correctness/useExhaustiveDependencies
security/noGlobalEval
style/noNonNullAssertion
a11y/noRedundantRoles
complexity/useFlatMap
correctness/useIsNan
style/useConst
suspicious/noGlobalIsFinite
suspicious/noSelfCompare
suspicious/noAsyncPromiseExecutor
suspicious/useGetterReturn
security/noDangerouslySetInnerHtml
style/useNodejsImportProtocol
a11y/noDistractingElements
nursery/useFocusableInteractive
complexity/noWith
suspicious/noArrayIndexKey
nursery/noInvalidDirectionInLinearGradient
suspicious/noDuplicateClassMembers
complexity/noExtraBooleanCast
performance/noAccumulatingSpread
a11y/useValidAriaProps
a11y/noRedundantAlt
correctness/noChildrenProp
suspicious/noConfusingLabels
nursery/useSemanticElements
nursery/useGenericFontNames
nursery/noDuplicateSelectorsKeyframeBlock
suspicious/noConfusingVoidType
a11y/useButtonType
suspicious/noFocusedTests
a11y/noAriaUnsupportedElements
correctness/noFlatMapIdentity
a11y/noBlankTarget
a11y/useHeadingContent
correctness/useValidForDirection
nursery/noDoneCallback
correctness/noVoidTypeReturn
correctness/noInvalidUseBeforeDeclaration
a11y/noAriaHiddenOnFocusable
a11y/useAnchorContent
complexity/noUselessRename
correctness/noInvalidNewBuiltin
style/useNumberNamespace
complexity/noUselessConstructor
a11y/noAccessKey
style/useExponentiationOperator
style/noUnusedTemplateLiteral
complexity/noUselessSwitchCase
nursery/noUnknownUnit
style/useSingleVarDeclarator
suspicious/noExportsInTest
a11y/noNoninteractiveElementToInteractiveRole
style/noCommaOperator
nursery/noUnknownProperty
suspicious/useIsArray
a11y/noHeaderScope
complexity/noUselessFragments
nursery/noDuplicateAtImportRules
complexity/noForEach
suspicious/noClassAssign
suspicious/noMisrefactoredShorthandAssign
suspicious/noFunctionAssign
Workspace:
Open Documents: 0Rule name
lint/complexity/noForEach
Playground link
Expected result
The lint rule lint/complexity/noForEach is very useful for plain arrays, and I would like to enable it.
I read the caveat on the rule page. In our codebase however, we use a lot of Effect, a functional programming library. Effect.forEach is used often enough that it would be bothersome to add biome-ignore comments to every usage.
Would it be feasible to make this rule configurable to ignore some objects?
Code of Conduct
- I agree to follow Biome's Code of Conduct
biomejs / biome
A toolchain for web projects, aimed to provide functionalities to maintain them. Biome offers formatter and linter, usable via CLI and LSP.
15.0k
Contributors get 70% of received funds after fees
How does funding with Polar work?
1
Pay now to fund the work behind this issue.
2
Get updates on progress being made.
3
Maintainer is rewarded once the issue is completed.
FAQ
Backer
You're funding impactful open source efforts
Contributor
You want to contribute to this effort
Maintainer
You want to get funding like this too