ConfigServer: File system watcher does not update internal config
It seems that the old_value field in the file system watcher is never updated to be the new one even if we have a change. This means that:
- If we change a value from X to Y, we can never change it back to X, since
ConfigServerthinks the value is always X - If we change a value from X to Y, and save the file repeatedly without any changes, messages are constantly sent to all listeners even though nothing in the config has changed.
I'm happy to attempt to fix this, but I'm not 100% sure how to go about this, any advice would be great!
Here's a demonstration video (Using #9639, with the fix from 317f55b applied): Video
SerenityOS / serenity
The Serenity Operating System 🐞
30.6k
Contributors get 100% of received funds after fees
How does funding with Polar work?
1
Pay now to fund the work behind this issue.
2
Get updates on progress being made.
3
Maintainer is rewarded once the issue is completed.
FAQ
Backer
You're funding impactful open source efforts
Contributor
You want to contribute to this effort
Maintainer
You want to get funding like this too