Fund: AK: Format as character only works with ASCII characters

The AK::Format format system can only format ASCII characters as {:c}. This is due to this function, which uses VERIFY to check if a character is valid ASCII. To implement Unicode support, it would be required to encode a possible multi-byte code point (meaning all values from 0x80) as UTF-8, similar to what StringBuilder::append_as_code_point does.

Here is the relevant code:

serenity/AK/Format.cpp

Lines 491 to 501 in ecaae2d

    
           void Formatter<T, typename EnableIf<IsIntegral<T>>::Type>::format(FormatBuilder& builder, T value) 
        
           { 
        
               if (m_mode == Mode::Character) { 
        
                   // FIXME: We just support ASCII for now, in the future maybe unicode? 
        
                   VERIFY(value >= 0 && value <= 127); 
        
                   m_mode = Mode::String; 
        
                   Formatter<StringView> formatter { *this }; 
        
                   return formatter.format(builder, StringView { reinterpret_cast<const char*>(&value), 1 }); 
        
               }

SerenityOS/serenity

AK: Format as character only works with ASCII characters

How does funding with Polar work?

Backer

Contributor

Maintainer

	void Formatter<T, typename EnableIf<IsIntegral<T>>::Type>::format(FormatBuilder& builder, T value)
	{
	if (m_mode == Mode::Character) {
	// FIXME: We just support ASCII for now, in the future maybe unicode?
	VERIFY(value >= 0 && value <= 127);

	m_mode = Mode::String;

	Formatter<StringView> formatter { *this };
	return formatter.format(builder, StringView { reinterpret_cast<const char*>(&value), 1 });
	}

SerenityOS/serenity

AK: Format as character only works with ASCII characters

How does funding with Polar work?

Backer

Why does "Fund on completion" require GitHub login?

When is the invoice due for "Fund on completion"?

What happens if the issue is never completed?

Do I get any extra benefits by funding?

Do I get progress updates?

Contributor

Do I get a reward?

Is rewards guaranteed?

Maintainer

How can I get funding like this for my open source initiatives?