Fund: LibWebSocket: Sending fragmented messages

This is an issue tracking status of sending fragmented messages, we don't need it now, but we will need it in the future for sure.

Support for receiving fragmented messages was done in #20925.

serenity/Userland/Libraries/LibWebSocket/WebSocket.cpp

Lines 532 to 541 in 75dfd69

    
           VERIFY(m_impl); 
        
           VERIFY(m_state == WebSocket::InternalState::Open); 
        
           u8 frame_head[1] = { (u8)((is_final ? 0x80 : 0x00) | ((u8)(op_code)&0xf)) }; 
        
           m_impl->send(ReadonlyBytes(frame_head, 1)); 
        
           // Section 5.1 : a client MUST mask all frames that it sends to the server 
        
           bool has_mask = true; 
        
           // FIXME: If the payload has a size > size_t max on a 32-bit platform, we could 
        
           //     technically stream it via non-final packets. However, the size was already 
        
           //     truncated earlier in the call stack when stuffing into a ReadonlyBytes 
        
           if (payload.size() > NumericLimits<u16>::max()) {

In this area we would have to:

introduce some buffer size aka how big the split messages should be and I saw that Blazor/SignalR is sending fragmented messages of 4096 bytes
buffer size should be configurable in the system somewhere
implement the code

SerenityOS/serenity

LibWebSocket: Sending fragmented messages

How does funding with Polar work?

Backer

Contributor

Maintainer

	VERIFY(m_impl);
	VERIFY(m_state == WebSocket::InternalState::Open);
	u8 frame_head[1] = { (u8)((is_final ? 0x80 : 0x00) \| ((u8)(op_code)&0xf)) };
	m_impl->send(ReadonlyBytes(frame_head, 1));
	// Section 5.1 : a client MUST mask all frames that it sends to the server
	bool has_mask = true;
	// FIXME: If the payload has a size > size_t max on a 32-bit platform, we could
	// technically stream it via non-final packets. However, the size was already
	// truncated earlier in the call stack when stuffing into a ReadonlyBytes
	if (payload.size() > NumericLimits<u16>::max()) {

SerenityOS/serenity

LibWebSocket: Sending fragmented messages

How does funding with Polar work?

Backer

Why does "Fund on completion" require GitHub login?

When is the invoice due for "Fund on completion"?

What happens if the issue is never completed?

Do I get any extra benefits by funding?

Do I get progress updates?

Contributor

Do I get a reward?

Is rewards guaranteed?

Maintainer

How can I get funding like this for my open source initiatives?