I'm currently building SerenityOS on WSL2, and I've got a local 2222 port already open for my local SSH server, it'd be great if the Meta/run.sh
script checked an already existing SERENITY_NETFLAG
environment variable and acted accordingly.
Running fails if I just run Meta/serenity.sh run
, and succeeds when making this change
diff --git a/Meta/run.sh b/Meta/run.sh
index 427fb5f294..7b12f9df62 100755
--- a/Meta/run.sh
+++ b/Meta/run.sh
@@ -249,7 +249,7 @@ if [ "$SERENITY_ARCH" = "aarch64" ]; then
SERENITY_NETFLAGS=
SERENITY_NETFLAGS_WITH_DEFAULT_DEVICE=
else
- SERENITY_NETFLAGS="-netdev user,id=breh,hostfwd=tcp:${SERENITY_HOST_IP}:8888-10.0.2.15:8888,hostfwd=tcp:${SERENITY_HOST_IP}:8823-10.0.2.15:23,hostfwd=tcp:${SERENITY_HOST_IP}:8000-10.0.2.15:8000,hostfwd=tcp:${SERENITY_HOST_IP}:2222-10.0.2.15:22"
+ SERENITY_NETFLAGS="-netdev user,id=breh,hostfwd=tcp:${SERENITY_HOST_IP}:8888-10.0.2.15:8888,hostfwd=tcp:${SERENITY_HOST_IP}:8823-10.0.2.15:23,hostfwd=tcp:${SERENITY_HOST_IP}:8000-10.0.2.15:8000,hostfwd=tcp:${SERENITY_HOST_IP}:3333-10.0.2.15:22"
SERENITY_NETFLAGS_WITH_DEFAULT_DEVICE="
$SERENITY_NETFLAGS
-device $SERENITY_ETHERNET_DEVICE_TYPE,netdev=breh
(you might need to scroll to the end to see the changed port but in summary I changed 2222 to 3333 just for testing and I'm able to boot into Serenity)
Pay now to fund the work behind this issue.
Get updates on progress being made.
Maintainer is rewarded once the issue is completed.
You're funding impactful open source efforts
You want to contribute to this effort
You want to get funding like this too