Fund: ConfigServer crashes when a domain has a "/" in it, and with it the whole GUI.

Doing a command like config a/a a a will crash everything that's connected to ConfigServer, as the server itself crashes. This is because of a verify within the source code triggered when it fails to open the domain, here it tries to access ~/.config/a/a.ini when the a directory doesn't exist.

serenity/Userland/Services/ConfigServer/ClientConnection.cpp

Lines 42 to 45 in 8d30e14

    
           auto watcher_or_error = Core::FileWatcher::create(InodeWatcherFlags::Nonblock); 
        
           VERIFY(!watcher_or_error.is_error()); 
        
           auto result = watcher_or_error.value()->add_watch(config->filename(), Core::FileWatcherEvent::Type::ContentModified); 
        
           VERIFY(!result.is_error());

SerenityOS/serenity

ConfigServer crashes when a domain has a "/" in it, and with it the whole GUI.

How does funding with Polar work?

Backer

Contributor

Maintainer

	auto watcher_or_error = Core::FileWatcher::create(InodeWatcherFlags::Nonblock);
	VERIFY(!watcher_or_error.is_error());
	auto result = watcher_or_error.value()->add_watch(config->filename(), Core::FileWatcherEvent::Type::ContentModified);
	VERIFY(!result.is_error());

SerenityOS/serenity

ConfigServer crashes when a domain has a "/" in it, and with it the whole GUI.

How does funding with Polar work?

Backer

Why does "Fund on completion" require GitHub login?

When is the invoice due for "Fund on completion"?

What happens if the issue is never completed?

Do I get any extra benefits by funding?

Do I get progress updates?

Contributor

Do I get a reward?

Is rewards guaranteed?

Maintainer

How can I get funding like this for my open source initiatives?