Fund: Kernel: `Processor::smp_wake_n_idle_processors` use over complicated copy ?

Kernel: Processor::smp_wake_n_idle_processors use over complicated copy ?

Hi,
I think there is an issue in the following code, detected while looking at bits functions:

serenity/Kernel/Arch/x86/common/Processor.cpp

Lines 779 to 784 in 986d634

    
           u32 found_mask = 0; 
        
           for (u32 i = 0; i < idle_count; i++) { 
        
               u32 cpu = bit_scan_forward(idle_mask) - 1; 
        
               idle_mask &= ~(1u << cpu); 
        
               found_mask |= 1u << cpu; 
        
           }

When extracted to https://godbolt.org/z/rTqxascfK and ran it shows that idle_mask is always copied to found_mask in an over-engineered way.
I don't fully understand what was the original intention, but I think this code can be simplified.

SerenityOS/serenity

Kernel: Processor::smp_wake_n_idle_processors use over complicated copy ?

How does funding with Polar work?

Backer

Contributor

Maintainer

	u32 found_mask = 0;
	for (u32 i = 0; i < idle_count; i++) {
	u32 cpu = bit_scan_forward(idle_mask) - 1;
	idle_mask &= ~(1u << cpu);
	found_mask \|= 1u << cpu;
	}

SerenityOS/serenity

Kernel: Processor::smp_wake_n_idle_processors use over complicated copy ?

How does funding with Polar work?

Backer

Why does "Fund on completion" require GitHub login?

When is the invoice due for "Fund on completion"?

What happens if the issue is never completed?

Do I get any extra benefits by funding?

Do I get progress updates?

Contributor

Do I get a reward?

Is rewards guaranteed?

Maintainer

How can I get funding like this for my open source initiatives?