LibJS: Strict mode error even though strict mode should not be active
This is a clone of SerenityOS/serenity#23240
Simplified reproduction:
function foo() {}
foo.argumentsOriginal issue:
1280.563 WebContent(1164): Unhandled JavaScript exception: [TypeError] Restricted function properties like 'callee', 'caller' and 'arguments' may not be accessed in strict mode
1280.563 WebContent(1164): at <unknown>
at WodItem (https://darkveil.world-of-dungeons.net/wod/javascript/orders.js?1702062237:224:16)
at https://darkveil.world-of-dungeons.net/wod/javascript/orders.js?1702062237:293:17
=> https://darkveil.world-of-dungeons.net/wod/javascript/orders.js
function WodItem(id, name, classes, ammoClassIds, equipped, equipped_sockets, unequipped_sockets) {
if (WodItem.arguments.length == 1) { // <- Error happens here
if (THE_ENV.items[id]) {
return THE_ENV.items[id]
} else {
this.id = id
this.name = WOD_STR.Wod.item.unknown
this.equipped = false
this.classes = classes
this.ammoClassIds = ammoClassIds
this.equipped_sockets = false
}
} else {
this.id = id
this.name = (equipped?'' : '!! ') + name
this.classes = classes
this.ammoClassIds = ammoClassIds
this.equipped = equipped
this.equipped_sockets = equipped_sockets
this.unequipped_sockets = unequipped_sockets
}
}Neither the file nor the function use strict mode. The code obviously works in Firefox.
LadybirdBrowser / ladybird
Truly independent web browser
21.3k
Contributors get 100% of received funds after fees
How does funding with Polar work?
1
Pay now to fund the work behind this issue.
2
Get updates on progress being made.
3
Maintainer is rewarded once the issue is completed.
FAQ
Backer
You're funding impactful open source efforts
Contributor
You want to contribute to this effort
Maintainer
You want to get funding like this too