Describe the Bug
The recent release that included PR #642 introduced a new setting, PAGINATION_DEFAULT_LIMIT, which is mentioned in the settings and pagination documentation sections.
However, upon reviewing the PR and the codebase, it appears that PAGINATION_DEFAULT_LIMIT is not actually currently referenced or used anywhere! This suggests that the setting is currently non-functional and does not affect pagination behavior.
Suggested Approach
We should either remove the PAGINATION_DEFAULT_LIMIT setting and its documentation, or implement its expected behaviour. Once the issue with is addressed, it would also be helpful to update the documentation to clarify that Relay pagination limits are controlled separately by the relay_max_results setting from the upstream strawberry package (if still applicable). This setting is documented in the Relay configuration guide.
System Information
- Operating system: MacOS
- Strawberry version (if applicable): 0.248.1
How does funding with Polar work?
Pay now to fund the work behind this issue.
Get updates on progress being made.
Maintainer is rewarded once the issue is completed.
Backer
You're funding impactful open source efforts
Contributor
You want to contribute to this effort
Maintainer
You want to get funding like this too